Arc - validate Event raw type injection points and throw DefinitionException when found #31085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
commented
Feb 10, 2023
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Beans.java
Outdated
Show resolved
Hide resolved
manovotn
commented
Feb 10, 2023
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Beans.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
mkouba
reviewed
Feb 13, 2023
...rc/test/java/io/quarkus/arc/test/event/injection/invalid/ProducerMethodEventRawTypeTest.java
Outdated
Show resolved
Hide resolved
manovotn
force-pushed
the
eventRawTypeValidation
branch
from
f6f704e to
1de2d2a
Compare
mkouba
reviewed
Feb 13, 2023
...endent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/InjectionPointInfo.java
Outdated
Show resolved
Hide resolved
manovotn
force-pushed
the
eventRawTypeValidation
branch
from
1de2d2a to
769c0c6
Compare
…ception when found
manovotn
force-pushed
the
eventRawTypeValidation
branch
from
769c0c6 to
241480c
Compare
mkouba
approved these changes
Feb 13, 2023
mkouba
added
the
triage/waiting-for-ci
Ladicek
approved these changes
Feb 13, 2023
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #28558
According to CDI spec, injecting a raw type of
Eventleads to aDefinitionExceptionwhich we so far didn't check.Tests mirror those in TCKs and should capture the scenarios in which this can potentially occur.